You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request adds the ability to accept other token signing algorithms, especially HS256, but with the possibility of extending to other algorithms as needed.
Thanks for offering this @MilnerMart, but there's already an existing request to support addition signing options in #5912. This is blocked though as I feel we need to define where our bounds of support lie as my comment in #5390 (comment).
Feel free to provide input on #5390 in regard to the draft criteria, or even open a feature request issue to specifically request HS256 support.
BookStack is now managed on Codeberg.
As part of this change, we're closing all existing GitHub issues and pull requests.
You'll instead find this issue on Codeberg here: https://codeberg.org/bookstack/bookstack/pulls/6110
Any further discussion for this will now be done primarily on Codeberg.
Since this thread was created relatively recently, it won't be locked just yet and we may still provide updates/responses here on GitHub, but it may be locked in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the ability to accept other token signing algorithms, especially HS256, but with the possibility of extending to other algorithms as needed.
Checklist